rename 'remove' to 'exclude' when referring to candidate list#73
Open
eoghanmurray wants to merge 1 commit into
Open
rename 'remove' to 'exclude' when referring to candidate list#73eoghanmurray wants to merge 1 commit into
eoghanmurray wants to merge 1 commit into
Conversation
…art attack when I saw that it was apparently 'removing' the vast proportion of the input files (whereas the message meant that the vast proportion of input files were being removed from the files that are going to be further processed!) - I've changed the term from 'remove' to 'exclude' when referencing the candidate list - The `-removeidentinode` option has been renamed to `-excludeidentinode`. Have left in support for previous option for backwards compatibility; hopefully I've done that right - In the README, the word remove is preserved when it is used as a synonym for delete: "I can now remove the one I consider a duplicate by hand if I want to" - For future consideration: the idea of there being a 'list' of files for consideration is really an internal implementation detail and shouldn't need to be exposed to the user IMO
Author
|
Sorry I don't understand the failing test output or whether it relates to the changes I've made? |
Owner
|
Sorry for the late reply. Internally, remove is ok to use in some places, as it has a well defined meaning in C++. I will have to think about which parts of this PR I want to adopt. Thanks for the writeup and patch! |
Author
|
Yep, feel free to just change the user visible output 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The word 'remove' is a synonym of 'delete', and nearly caused me a heart attack when I saw that it was apparently 'removing' the vast proportion of the input files (whereas the message meant that the vast proportion of input files were being removed from the files that are going to be further processed!)
-removeidentinodeoption has been renamed to-excludeidentinode. Have left in support for previous option for backwards compatibility; hopefully I've done that right