Conversation
Black Duck Security ReportMerging #170 into master will not change security risk. Added ComponentsClean: 12 |
|
|
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| this.preference = preference; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| @@ -0,0 +1,99 @@ | |||
| package jp.ne.paypay.model; | |||
There was a problem hiding this comment.
Similar blocks of code found in 10 locations. Consider refactoring.
|
|
||
| private Call checkWalletBalanceValidateBeforeCall(String userAuthorizationId, Integer amount, String currency, ProductType productType) throws ApiException { | ||
|
|
||
| private Call validateCheckWalletBalanceParamsBeforeCall(String endpoint, String userAuthorizationId, Integer amount, String currency, ProductType productType) throws ApiException { |
There was a problem hiding this comment.
Method validateCheckWalletBalanceParamsBeforeCall has 5 arguments (exceeds 4 allowed). Consider refactoring.
|
|
||
| */ | ||
| private Call checkWalletBalanceCall(String userAuthorizationId, Integer amount, String currency, | ||
| private Call walletBalanceCall(String endpoint, String userAuthorizationId, Integer amount, String currency, |
There was a problem hiding this comment.
Method walletBalanceCall has 5 arguments (exceeds 4 allowed). Consider refactoring.
| this.cashbackAutoInvestment = cashbackAutoInvestment; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Method equals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit ae41ef6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 84.6% (5% is the threshold). This pull request will bring the total coverage in the repository to 86.4% (0.0% change). View more on Code Climate. |
| this.data = data; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Method equals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
curtisfennerpaypay
left a comment
curtisfennerpaypay
left a comment
There was a problem hiding this comment.
Please also update the documentation in the readme and in the docs/ folder
4 participants
All Submissions:
New Feature Submissions:
Changes to Core Features: