Skip to content

feat: adjust output to pipetester requirements#35

Open
FRutkowski wants to merge 26 commits into
masterfrom
feat/output-pipetester
Open

feat: adjust output to pipetester requirements#35
FRutkowski wants to merge 26 commits into
masterfrom
feat/output-pipetester

Conversation

@FRutkowski
Copy link
Copy Markdown
Collaborator

No description provided.

@FRutkowski FRutkowski requested a review from wvffle June 11, 2023 22:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.32 ⚠️

Comparison is base (9502739) 97.11% compared to head (d08c4c7) 96.79%.

❗ Current head d08c4c7 differs from pull request most recent head aa5fa9f. Consider uploading reports for the commit aa5fa9f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   97.11%   96.79%   -0.32%     
==========================================
  Files           9        9              
  Lines         936      937       +1     
==========================================
- Hits          909      907       -2     
- Misses         27       30       +3     
Impacted Files Coverage Δ
ats/pkb/utils.py 93.84% <ø> (ø)
ats/pkb/query_evaluator.py 96.11% <60.00%> (-2.91%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread simple.txt
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

co to za plik? w katalogu tests jest miejsce odpowiednie na testy do pipetestera

Comment thread main.py Outdated
Comment thread main.py
print("Ready")
while True:
try:
t = Timer(60, no_time_left)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kiedy to ma sprawdzac?

Copy link
Copy Markdown
Collaborator

@KamiloSzcz KamiloSzcz Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aż nie ma zapytań

Comment thread ats/pkb/design_extractor.py Outdated
Comment on lines +149 to +156
"""extend_parents = []
for name in call_order:
if name in proc_parents:
proc_parents[name].extend(extend_parents)
proc_parents[name] = list(set(proc_parents[name]))
extend_parents.extend(proc_parents[name])
else:
extend_parents = []
extend_parents = []"""
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?????

Comment on lines +103 to +104
if param == relation["parameters"][0]:
return context["procedures"][param[1:-1]]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ale wiecie ze to moze byc rowniez stmt?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +103 to +104
if param == relation["parameters"][0]:
return context["procedures"][param[1:-1]]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +122 to +123
if param == relation["parameters"][0]:
return context["procedures"][param[1:-1]]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread main.py

if __name__ == "__main__":
sys.stdout.reconfigure(encoding="utf-8")
sys.stdout.reconfigure(encoding="utf-8") # nie powinno być ibm852?
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to zmiencie?

@wvffle wvffle force-pushed the feat/output-pipetester branch from 554ef67 to 3b8cb6c Compare June 13, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants