Skip to content

cmd: Merge decode/encode into a single cobs command#36

Merged
pdgendt merged 8 commits into
mainfrom
cmd-cobs
Mar 23, 2026
Merged

cmd: Merge decode/encode into a single cobs command#36
pdgendt merged 8 commits into
mainfrom
cmd-cobs

Conversation

@pdgendt

@pdgendt pdgendt commented Mar 23, 2026

Copy link
Copy Markdown
Owner

Use subcommands for decode and encode, the main command is 'cobs'.

@codecov

codecov Bot commented Mar 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.34146% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.46%. Comparing base (b1c3a84) to head (e81b7cf).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cobs/main.go 96.34% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   98.26%   97.46%   -0.80%     
==========================================
  Files           1        2       +1     
  Lines         115      197      +82     
==========================================
+ Hits          113      192      +79     
- Misses          1        4       +3     
  Partials        1        1              
Files with missing lines Coverage Δ
cmd/cobs/main.go 96.34% <96.34%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/cobs/main.go Outdated
Comment thread cmd/cobs/main.go Outdated
Comment thread cmd/cobs/main.go Outdated
@pdgendt pdgendt marked this pull request as ready for review March 23, 2026 12:09
@pdgendt pdgendt requested a review from Copilot March 23, 2026 12:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/cobs/main.go Outdated
Comment thread cmd/cobs/main.go Outdated
pdgendt added 6 commits March 23, 2026 13:30
Use subcommands for decode and encode, the main command is 'cobs'.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Add a flag to print the current version.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Replace write with Write

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Do not use panic in user-facing shell commands.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Add a usage printout and add a help subcommand.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Make the main funtion a simple wrapper around a run function.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
pdgendt added 2 commits March 23, 2026 14:02
Test the run function for the cobs command.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Add cmd to the coverage tests.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
@pdgendt pdgendt merged commit efce244 into main Mar 23, 2026
7 of 9 checks passed
@pdgendt pdgendt deleted the cmd-cobs branch March 23, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants