Aspect ratio calculation didn't fit my needs#15
Open
bluthg wants to merge 1 commit into
Open
Conversation
…on (basically, enlarge or shrink to fit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a lot of scanned pictures for a slideshow, in different aspect ratios. Many of them, if not most, were far too large once scaled to fit the screen.
So this PR adds an option "--aspect-ratio-target" that modifies the AR calculation (basically, "max" to enlarge or "min" to fit the whole picture on the screen).
Apart from that: awesome work, exactly what I was looking for!