fix: free handles after stop (Windows)#12
Merged
pevers merged 1 commit intopevers:mainfrom Nov 20, 2025
Merged
Conversation
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
pevers
requested changes
Nov 19, 2025
Owner
pevers
left a comment
There was a problem hiding this comment.
Thanks for taking the time to fix this! I've a small suggestion to implement it as Drop.
Free handles after stop so that wen can do prevent_display_sleep after stop.
Contributor
Author
|
@pevers, thanks for review! I've updated the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free handles after stop so that wen can do prevent_display_sleep after stop.
Note
Close Windows power request handles on stop, reset internal state, add drop-based cleanup, and test restarting after stop.
PowerClearRequestwithCloseHandlefor bothsystem_handleand optionaldisplay_handleinnosleep-windows/src/lib.rs.self.no_sleep_handle = Noneafter closing.DropforNoSleepto automatically callstop().test_start_after_stopto verify starting afterstop().CloseHandletowindows::Win32::Foundationand remove unused power-clear import.Written by Cursor Bugbot for commit 7df050e. This will update automatically on new commits. Configure here.