Skip to content

chore(deps): bump electron 41.5.0 -> 42.1.0 and pin packaged version #9959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asheshv wants to merge 1 commit into
base: master
Choose a base branch
from
+50 −399
Open

chore(deps): bump electron 41.5.0 -> 42.1.0 and pin packaged version #9959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/linux/build-functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,16 @@ _build_runtime() {
ELECTRON_ARCH="arm64"
fi

ELECTRON_VERSION="$(npm info electron version)"
# Resolve the electron version from runtime/package.json, NOT from
# `npm info electron version`. The latter fetches whatever currently
# carries the `latest` dist-tag on the npm registry, which means any
# newly published electron release lands in shipped binaries without
# review. Keep the build deterministic and pinned.
ELECTRON_VERSION=$(sed -nE 's/.*"electron":[[:space:]]*"\^?([0-9.]+)".*/\1/p' "${SOURCEDIR}/runtime/package.json" | head -1)
if [ -z "${ELECTRON_VERSION}" ]; then
echo "ERROR: could not resolve electron version from runtime/package.json" >&2
exit 1
fi

pushd "${BUILDROOT}" > /dev/null || exit
while true;do
Expand Down
11 changes: 10 additions & 1 deletion pkg/mac/build-functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,16 @@ _build_runtime() {

test -d "${BUILD_ROOT}" || mkdir "${BUILD_ROOT}"
# Get a fresh copy of electron
ELECTRON_VERSION="$(npm info electron version)"
# Resolve the electron version from runtime/package.json, NOT from
# `npm info electron version`. The latter fetches whatever currently
# carries the `latest` dist-tag on the npm registry, which means any
# newly published electron release lands in shipped binaries without
# review. Keep the build deterministic and pinned.
ELECTRON_VERSION=$(sed -nE 's/.*"electron":[[:space:]]*"\^?([0-9.]+)".*/\1/p' "${SOURCE_DIR}/runtime/package.json" | head -1)
if [ -z "${ELECTRON_VERSION}" ]; then
echo "ERROR: could not resolve electron version from runtime/package.json" >&2
exit 1
fi

pushd "${BUILD_ROOT}" > /dev/null || exit
while true;do
Expand Down
2 changes: 1 addition & 1 deletion runtime/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"packageManager": "yarn@4.9.2",
"devDependencies": {
"@eslint/js": "^10.0.1",
"electron": "^41.5.0",
"electron": "^42.1.0",
"eslint": "^10.4.0",
"eslint-plugin-unused-imports": "^4.4.1",
"globals": "^17.6.0"
Expand Down
Loading
Loading