cargo-pgrx: add --valgrind flag to cargo pgrx regress#2290
Open
philippemnoel wants to merge 1 commit into
Open
cargo-pgrx: add --valgrind flag to cargo pgrx regress#2290philippemnoel wants to merge 1 commit into
cargo pgrx regress#2290philippemnoel wants to merge 1 commit into
Conversation
`cargo pgrx start` and `cargo pgrx run` already accept `--valgrind` and the underlying `start_postgres` already knows how to launch Postgres under valgrind, but the flag was not exposed on `cargo pgrx regress`: `From<&Regress> for Run` hardcoded `valgrind: false`, so there was no way to run the regression suite under valgrind without manually starting Postgres first. This adds the flag to `Regress` and propagates it through to `Run`.
Contributor
Author
|
The "verify package can build / ubuntu" run will be fixed once #2292 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo pgrx startandcargo pgrx runalready accept--valgrind, and the underlyingstart_postgresalready knows how to launch Postgres under valgrind. But the flag was not exposed oncargo pgrx regress—From<&Regress> for Runhardcodedvalgrind: false, so there was no way to run the regression suite under valgrind without manually starting Postgres beforehand.This adds
--valgrindtoRegressand propagates it through toRun. No new mechanism — just plumbing.Test plan
cargo check -p cargo-pgrxpassescargo pgrx regress --helpshows the new--valgrindflagcargo pgrx regress --valgrindruns the regression suite under valgrind end-to-end