Skip to content

CI issues with version check script #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phodge wants to merge 7 commits into from
Closed

CI issues with version check script #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d2fd004
***check versiond emo
phodge May 2, 2026
c6d16c0
***bin/ci/check_versions.sh: many debug
phodge May 2, 2026
404bccf
***why logic bad?
phodge May 2, 2026
3284b32
***bring back GOOD
phodge May 2, 2026
8411898
***rewrite from Claude
phodge May 2, 2026
6473758
***get rid of redirect
phodge May 2, 2026
44ea8e2
***bin/ci/check_versions.sh: bring back simple redirect
phodge May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/automated-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,13 @@ jobs:
- run: uv run mypy homely test
# also verify homely will run on latest python
- run: uv run mypy --python-version=3.14 homely test
CheckVersionsDemo:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.x"
- run: sh bin/ci/check_versions.sh "0.23.1"
10 changes: 9 additions & 1 deletion bin/ci/check_versions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,16 @@ expected_version="$1"
shift

if [ -n "$expected_version" ]; then
if ! grep "^version = \"$expected_version\"" homely/__init__.py &>/dev/null; then
echo '----------'
cat homely/__init__.py
echo '----------'
grep "^version = \"$expected_version\"" homely/__init__.py
echo $?
echo '----------'
if ! grep "^version = \"$expected_version\"" homely/__init__.py >/dev/null; then
echo "ERROR: expected 'version = \"$expected_version\"' in homely/__init__.py" >&2
exit 3
else
echo "OK: version in homely/__init__.py matches expected version '$expected_version'"
fi
fi
Loading