Optimize async pid collection#4218
Closed
preciz wants to merge 2 commits intophoenixframework:mainfrom
Closed
Conversation
Collaborator
|
Actually, in this case I'd say performance is not be the highest goal, as this is test only code (only called when you |
By accumulating the async PIDs into a list instead of a Map, we can avoid the final Map.keys() call. PIDs are guaranteed to be unique because they represent unique spawned tasks and cannot be duplicated within the live_async state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid allocating intermediate maps and their merges.
2-3x faster.