Fix Is(Not)Abstract expression so that it does not ignore final classes #560
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have this rule in our codebase (and other similar rules too):
Basically we want to make sure that all test class names in our testsuite that extend the base
EndToEndTestCaseclass that are not abstract classes themselves must end withEndToEndTest.After #454 this no longer works as the logic early returns in
\Arkitect\Rules\Specs::allSpecsAreMatchedBybecause\Arkitect\Expression\ForClasses\IsNotAbstract::appliesToreturnsfalsefor final classes (and all our test classes are final) and because of that the\Arkitect\Expression\ForClasses\HaveNameMatchingexpression never gets evaluated so no violations are reported.After this fix
appliesTowould returntrueand everything would continue to work as it did prior to that #454 PR.