Skip to content

TypeCombinator: Remove unnecessary md5 encoding #4658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into from
Dec 23, 2025
+1 −2
Merged

TypeCombinator: Remove unnecessary md5 encoding #4658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Type/TypeCombinator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
use function count;
use function get_class;
use function is_int;
use function md5;
use function sprintf;
use function usort;
use const PHP_INT_MAX;
Expand Down Expand Up @@ -197,7 +196,7 @@ public static function union(Type ...$types): Type
for ($i = 0; $i < $typesCount; $i++) {
if ($types[$i]->isConstantScalarValue()->yes()) {
$type = $types[$i];
$scalarTypes[get_class($type)][md5($type->describe(VerbosityLevel::cache()))] = $type;
$scalarTypes[get_class($type)][$type->describe(VerbosityLevel::cache())] = $type;
unset($types[$i]);
continue;
}
Expand Down
Loading