Skip to content

feat(ui): add active/inactive panel border colors #122

Closed
vaishnavi003-svg wants to merge 2 commits into
pie-314:devfrom
vaishnavi003-svg:fix/panel-border-colors
Closed

feat(ui): add active/inactive panel border colors #122
vaishnavi003-svg wants to merge 2 commits into
pie-314:devfrom
vaishnavi003-svg:fix/panel-border-colors

Conversation

@vaishnavi003-svg

Copy link
Copy Markdown

Description

Adds visual distinction between active and inactive panels by changing border colors.

  • Active panel: Bright border (highlight_color)
  • Inactive panels: Dim gray border (border_color)

Fixes #71

Type of Change

  • New feature (non-breaking change)

How Has This Been Tested?

  • Manual testing

Test Steps:

  1. Run cargo run to start the TUI
  2. Press Tab to switch panels — active panel border becomes bright
  3. Press e to enter search mode — search input border becomes bright
  4. Press j/k in details pane — details panel border becomes bright

Screenshots

(Add screenshot here — drag and drop
Screenshot 2026-06-05 124733
)

Checklist

@vercel

vercel Bot commented Jun 5, 2026

Copy link
Copy Markdown

@vaishnavi003-svg is attempting to deploy a commit to the pie's projects Team on Vercel.

A member of the Team first needs to authorize it.

@pie-314

pie-314 commented Jun 5, 2026

Copy link
Copy Markdown
Owner

@vaishnavi003-svg resolve conflicts and submit SS for other themes.

@vaishnavi003-svg

Copy link
Copy Markdown
Author

Conflicts Resolved

I have resolved the conflicts.
The PR is now conflict-free and ready for review.

@vaishnavi003-svg

Copy link
Copy Markdown
Author

Screenshots - Theme Comparison

Nord Theme (Settings Tab)

Border Color Behavior

  • Active panel (Settings tab): Bright border
  • Inactive panels: Dim gray border

Testing Done

  • Theme changes reflect correctly
  • Active/Inactive border colors work across all tabs
  • No build errors or warnings
Screenshot 2026-06-05 155834 Screenshot 2026-06-05 160411

Conflicts resolved. Ready for review.

@pie-314

pie-314 commented Jun 6, 2026

Copy link
Copy Markdown
Owner

@vaishnavi003-svg your code is failing CI

@vaishnavi003-svg vaishnavi003-svg force-pushed the fix/panel-border-colors branch from 1baab38 to 0a45ba3 Compare June 6, 2026 07:46
@vaishnavi003-svg

Copy link
Copy Markdown
Author

✅ CI fixed - removed extra closing brace in draw.rs (line 717). Ready for review.

@pie-314

pie-314 commented Jun 6, 2026

Copy link
Copy Markdown
Owner
image I am closing this PR

@pie-314 pie-314 closed this Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants