Skip to content

feat(ui): add interactive keybinding editor to settings menu#124

Open
sansitachaudhury wants to merge 2 commits into
pie-314:mainfrom
sansitachaudhury:main
Open

feat(ui): add interactive keybinding editor to settings menu#124
sansitachaudhury wants to merge 2 commits into
pie-314:mainfrom
sansitachaudhury:main

Conversation

@sansitachaudhury

@sansitachaudhury sansitachaudhury commented Jun 5, 2026

Copy link
Copy Markdown

Description

added a interactive keybinding editor sub menu in settings tab which will allow users to rebind all application control hotkeys dynamically from TUI interface & remove the need to manually edit the config.toml file

Fixes # (issue #59 )

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual test (please describe): launched TUI with cargo run moved to settings tab then verified that both arrow keys and the mouse scroll down through keybinding options. Then I triggered a rebind using Enter and also confirmed the config wrote to config.toml

  • cargo test

Checklist:

  • My code follows the Coding Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have NOT added useless AI-generated comments.
  • I have NOT deleted existing unrelated comments.
  • I have NOT modified files unrelated to this task.
  • I have included screenshots/recordings (for UI changes).
  • My changes generate no new warnings (clippy/fmt).
  • I have linked the issue I am working on.

Screenshots (if applicable)

image

@vercel

vercel Bot commented Jun 5, 2026

Copy link
Copy Markdown

@sansitachaudhury is attempting to deploy a commit to the pie's projects Team on Vercel.

A member of the Team first needs to authorize it.

@pie-314

pie-314 commented Jun 6, 2026

Copy link
Copy Markdown
Owner

@sansitachaudhury Screenshot/screen recording is applicable

@sansitachaudhury

Copy link
Copy Markdown
Author

@pie-314 I have updated with screenshot

@pie-314

pie-314 commented Jun 6, 2026

Copy link
Copy Markdown
Owner

@sansitachaudhury

Few issues

  • it's not scrolling
  • it's rendering half
  • UI looks bad

I suggest you to use other side of screen for editing keybinds or a popup menu

@sansitachaudhury

Copy link
Copy Markdown
Author
image

this is the improvement from the previous one
made the UI look clean and it's scrolling
image

@pie-314

pie-314 commented Jun 23, 2026

Copy link
Copy Markdown
Owner

@sansitachaudhury It looks good i suggest you to use right side of screen for better visibility, at the same time scroll is not working properly neither arrows keys are going to bottom two options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants