feat(ui): add interactive keybinding editor to settings menu#124
Open
sansitachaudhury wants to merge 2 commits into
Open
feat(ui): add interactive keybinding editor to settings menu#124sansitachaudhury wants to merge 2 commits into
sansitachaudhury wants to merge 2 commits into
Conversation
|
@sansitachaudhury is attempting to deploy a commit to the pie's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@sansitachaudhury Screenshot/screen recording is applicable |
Author
|
@pie-314 I have updated with screenshot |
Owner
|
Few issues
I suggest you to use other side of screen for editing keybinds or a popup menu |
Author
Owner
|
@sansitachaudhury It looks good i suggest you to use right side of screen for better visibility, at the same time scroll is not working properly neither arrows keys are going to bottom two options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
added a interactive keybinding editor sub menu in settings tab which will allow users to rebind all application control hotkeys dynamically from TUI interface & remove the need to manually edit the
config.tomlfileFixes # (issue #59 )
Type of Change
How Has This Been Tested?
Manual test (please describe): launched TUI with
cargo runmoved to settings tab then verified that both arrow keys and the mouse scroll down through keybinding options. Then I triggered a rebind usingEnterand also confirmed the config wrote to config.tomlcargo testChecklist:
Screenshots (if applicable)