Eliminate unneeded work when missing signing keys#96
Open
smcmurray wants to merge 2 commits intopillarjs:masterfrom
smcmurray:patch-1
Open
Eliminate unneeded work when missing signing keys#96smcmurray wants to merge 2 commits intopillarjs:masterfrom smcmurray:patch-1
smcmurray wants to merge 2 commits intopillarjs:masterfrom
smcmurray:patch-1
Conversation
0 is a legitimate value for maxAge. If there are no signing keys, you can abort sooner. There's no need to parse the signature cookie, etc. if you already know you will fail.
dougwilson
suggested changes
May 20, 2018
Contributor
dougwilson
left a comment
dougwilson
left a comment
There was a problem hiding this comment.
Can you split this into two separate pull requests and add tests for the maxAge change?
dougwilson
changed the title
dougwilson
approved these changes
Sep 10, 2018
Contributor
|
Hi @smcmurray sorry this fell off my radar. Thanks for moving the maxAge into a different PR. I was actually just about to merge this, but realized it actually has a behavior change with this: When reading a non-signed cookie with I think this PR is the right change of behavior, though, and will put it into the 0.8.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0 is a legitimate value for maxAge.
If there are no signing keys, you can abort sooner. There's no need to parse the signature cookie, etc. if you already know you will fail.