perf: optimize collapseLeadingSlashes function#254
Open
Phillip9587 wants to merge 1 commit intopillarjs:masterfrom
Open
perf: optimize collapseLeadingSlashes function#254Phillip9587 wants to merge 1 commit intopillarjs:masterfrom
Phillip9587 wants to merge 1 commit intopillarjs:masterfrom
Conversation
UlisesGascon
approved these changes
May 9, 2025
bjohansebas
approved these changes
May 10, 2025
Member
bjohansebas
left a comment
There was a problem hiding this comment.
I'm not sure this is a performance improvement, but I still think it's a good change.
Contributor
|
What do you guys think of this? function collapseLeadingSlashes(str) {
return str.replace(/^\/+/, "/")
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified the
collapseLeadingSlashesfunction by combining the loop condition and increment into a single line, and replaced the deprecatedsubstrmethod with the more modernslicemethod for better compatibility.