Skip to content

Remove use of Math.random() #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fidian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove use of Math.random() #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ interface Computed<T> {
get: () => T;
}

let conaKey = 0;

export class Cona extends HTMLElement {
private _op: Props;
private props: Props;
Expand Down Expand Up @@ -156,14 +158,11 @@ export class Cona extends HTMLElement {

if (s.endsWith("=")) {
if (/(p:|on|ref).*$/.test(s)) {
const key = Math.random().toString(36);

Cona._c[key] =
valueString = conaKey++;
Cona._c[valueString] =
typeof currentValue === "function"
? currentValue.bind(this)
: currentValue;

valueString = key;
} else valueString = JSON.stringify(currentValue);
} else if (Array.isArray(currentValue)) {
valueString = currentValue.join("");
Expand Down