Add clickhouse timeout#293
Merged
Merged
Conversation
- Add CLICKHOUSE_REQUEST_TIMEOUT_MS config (default 30s) - Apply timeout to all ClickHouse client instances (query, insert, setup) - Implement AbortController-based timeout for query() operations - Add launch.json to .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a configurable timeout for ClickHouse HTTP requests to prevent indefinitely hung queries, particularly addressing issues when running under Bun. It also updates the documentation and configuration files to support this new setting. Additionally, there are various formatting improvements and minor test refactors for better readability and maintainability.
ClickHouse request timeout improvements:
CLICKHOUSE_REQUEST_TIMEOUT_MS(default: 30,000ms) to control the timeout for ClickHouse HTTP requests, with documentation explaining its importance and usage. [1] [2] [3]lib/clickhouse.tsto use the new timeout value for all client instances. [1] [2] [3]queryfunction to abort requests that exceed the configured timeout, ensuring resources are cleaned up and errors are tracked appropriately. [1] [2] [3]Documentation:
docs/CONFIGURATION.mdto document the newCLICKHOUSE_REQUEST_TIMEOUT_MSenvironment variable, its default value, and guidance for users.Test and formatting improvements:
lib/logger.tsfor improved code style consistency.