Skip to content

Conversation

@Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Dec 31, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

v8.5.4: tikv: update auto compaction config

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt self-assigned this Dec 31, 2025
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Dec 31, 2025
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 31, 2025
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Dec 31, 2025

/cc @v01dstar @qiancai

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 31, 2025

@Oreoxmt: GitHub didn't allow me to request PR reviews from the following users: v01dstar.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @v01dstar @qiancai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot requested a review from qiancai December 31, 2025 03:07
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 31, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 31, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-31 03:13:59.539596193 +0000 UTC m=+153595.357904625: ☑️ agreed by qiancai.

Oreoxmt and others added 2 commits December 31, 2025 11:32
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 5, 2026

@v01dstar: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Oreoxmt Oreoxmt added the lgtm label Jan 5, 2026
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jan 5, 2026

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 5, 2026
@ti-chi-bot ti-chi-bot bot merged commit 436d1fb into pingcap:master Jan 5, 2026
7 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 5, 2026
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #21240.
But this PR has conflicts, please resolve them!

@Oreoxmt Oreoxmt deleted the gc-auto-compaction-v854 branch January 6, 2026 07:18
Oreoxmt added a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants