Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #22196

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. labels Dec 31, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances TiDB's query optimization capabilities by introducing new optimizer hints and a system variable related to IndexLookUp pushdown. These additions provide users with finer control over how IndexLookUp operations are executed, allowing for potential performance improvements by pushing these operations closer to the data storage layer (TiKV). The changes primarily involve updating documentation to reflect these new features.

Highlights

  • New Optimizer Hint: INDEX_LOOKUP_PUSHDOWN: Introduced the INDEX_LOOKUP_PUSHDOWN hint, allowing users to explicitly instruct the optimizer to push down the IndexLookUp operator to TiKV for execution, along with its usage, example execution plan, and a comprehensive list of current limitations.
  • New Optimizer Hint: NO_INDEX_LOOKUP_PUSHDOWN: Added the NO_INDEX_LOOKUP_PUSHDOWN hint, which provides a mechanism to explicitly disable IndexLookUp pushdown for a specified table, especially when the tidb_index_lookup_pushdown_policy system variable is set to force or affinity-force. This hint takes precedence over INDEX_LOOKUP_PUSHDOWN.
  • New System Variable: tidb_index_lookup_pushdown_policy: Documented the new tidb_index_lookup_pushdown_policy system variable, which controls whether and when TiDB pushes the IndexLookUp operator down to TiKV. It offers three value options: hint-only (default), affinity-force, and force.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the new Index Lookup Pushdown feature, including the INDEX_LOOKUP_PUSHDOWN and NO_INDEX_LOOKUP_PUSHDOWN hints, and the tidb_index_lookup_pushdown_policy system variable. The changes are clear and well-structured. I have a couple of minor suggestions to improve readability and provide more context for readers.

@Oreoxmt Oreoxmt changed the title Add index lookup push down content (#22196) v8.5.5: Add index lookup push down content (#22196) Dec 31, 2025
@Oreoxmt Oreoxmt changed the base branch from release-8.5 to feature/preview-v8.5.5 December 31, 2025 07:24
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 31, 2025
@Oreoxmt Oreoxmt force-pushed the cherry-pick-22196-to-release-8.5 branch from 3ef16f8 to 47ca2b8 Compare December 31, 2025 07:32
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oreoxmt. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Oreoxmt Oreoxmt force-pushed the cherry-pick-22196-to-release-8.5 branch from 47ca2b8 to f912e2e Compare December 31, 2025 07:35
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants