Skip to content

stability-test-release-8.5 - 2026-01-02 06:01:46 #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hongyunyan wants to merge 1 commit into from
Closed

stability-test-release-8.5 - 2026-01-02 06:01:46 #3884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,3 +342,4 @@ workload: tools/bin/workload

generate-next-gen-grafana:
./scripts/generate-next-gen-metrics.sh

Copy link

@gemini-code-assist gemini-code-assist bot Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change introduces a second trailing blank line to the file. While this particular change is harmless, it suggests the automation script that created this PR might be flawed, as it adds a newline unconditionally instead of ensuring exactly one exists. If this script runs repeatedly, it could add many extra newlines to the file, creating unnecessary noise in diffs. It would be best to make the script idempotent to only add a newline if one is missing.