Skip to content

stability-test - 2026-01-04 02:00:42 #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hongyunyan wants to merge 1 commit into from
Closed

stability-test - 2026-01-04 02:00:42 #3903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,3 +342,4 @@ workload: tools/bin/workload

generate-next-gen-grafana:
./scripts/generate-next-gen-metrics.sh

Copy link

@gemini-code-assist gemini-code-assist bot Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There's a critical issue in a script related to the code in this hunk. The generate-next-gen-grafana target calls scripts/generate-next-gen-metrics.sh. This script has a typo on line 65: $NEXT_gen_USER_FILE should be $NEXT_GEN_USER_FILE. Since the script runs with set -u, this will cause an 'unbound variable' error and make the make check command fail. I'm adding this comment here as the bug is not in a changed file, but it's critical to the stability of the checks.