Skip to content

Optimize marketing navbar logo image #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sabraman wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

Optimize marketing navbar logo image #1750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added apps/marketing/src/assets/app-icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 11 additions & 1 deletion apps/marketing/src/layouts/Layout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
---
import { Image } from "astro:assets";
import navIcon from "../assets/app-icon.png";
Copy link
Copy Markdown
Contributor

@macroscopeapp macroscopeapp bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical layouts/Layout.astro:3

The import path ../../../assets/prod/black-ios-1024.png resolves to apps/assets/prod/black-ios-1024.png, which does not exist. The actual asset is at assets/prod/black-ios-1024.png. This causes a build failure when Astro attempts to resolve the image import.

Suggested change
import navIcon from "../assets/app-icon.png";
import navIcon from "../../../../assets/prod/black-ios-1024.png";
🤖 Copy this AI Prompt to have your agent fix this: 
In file apps/marketing/src/layouts/Layout.astro around line 3:

The import path `../../../assets/prod/black-ios-1024.png` resolves to `apps/assets/prod/black-ios-1024.png`, which does not exist. The actual asset is at `assets/prod/black-ios-1024.png`. This causes a build failure when Astro attempts to resolve the image import.

Copy link
Copy Markdown
Contributor

@cursor cursor bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong image asset used for navbar logo

Medium Severity

The navIcon import in Layout.astro uses app-icon.png, the padded icon, instead of the unpadded icon.png previously displayed. Despite a confirmed fix, the import was not updated, and src/assets lacks the correct unpadded asset, causing the navbar to show the wrong artwork.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 51aae21. Configure here.


interface Props {
title?: string;
description?: string;
Expand Down Expand Up @@ -31,7 +34,14 @@ const {
<div class="page">
<nav class="nav">
<a href="/" class="nav-brand">
<img src="/icon.png" alt="T3" class="nav-icon" />
<Image
src={navIcon}
alt="T3"
width={28}
height={28}
priority
class="nav-icon"
/>
Comment on lines +37 to +44
Copy link
Copy Markdown
Contributor

@macroscopeapp macroscopeapp bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High layouts/Layout.astro:36

The priority prop on the Image component is not a valid Astro prop. Astro's Image component from astro:assets uses loading="eager" for priority loading, not priority. The priority attribute is passed through to the HTML as a custom data attribute that browsers ignore, so the intended eager loading behavior does not occur.

            src="/icon.png"
            alt="T3"
            width={28}
            height={28}
-            priority
+            loading="eager"
            class="nav-icon"
🤖 Copy this AI Prompt to have your agent fix this: 
In file apps/marketing/src/layouts/Layout.astro around lines 36-43:

The `priority` prop on the `Image` component is not a valid Astro prop. Astro's Image component from `astro:assets` uses `loading="eager"` for priority loading, not `priority`. The `priority` attribute is passed through to the HTML as a custom data attribute that browsers ignore, so the intended eager loading behavior does not occur.

Copy link
Copy Markdown
Contributor Author

@sabraman sabraman Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astro 6 does support priority on astro:assets Image. It maps to eager loading, sync decoding, and high fetch priority for above-the-fold images, so I'm keeping that as-is.

I verified this against the current Astro docs before updating the branch.

Copy link
Copy Markdown
Contributor

@macroscopeapp macroscopeapp bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

</a>
<a
href="https://github.com/pingdotgg/t3code"
Expand Down
Loading