Skip to content

Codex/skills appserver handoff #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Emanuele-web04 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Codex/skills appserver handoff #1766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebb63fd
Add thread handoff metadata and message source tracking
Emanuele-web04 Apr 5, 2026
e7ba59f
Prevent re-handoff before native chat messages exist
Emanuele-web04 Apr 5, 2026
c5cea3f
Add visible chat shortcuts and Claude skill discovery
Emanuele-web04 Apr 5, 2026
5e5f8d2
Port Codex app-server discovery and manager updates
Emanuele-web04 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 73 additions & 32 deletions apps/server/src/checkpointing/Layers/CheckpointDiffQuery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,38 +1,83 @@
import { CheckpointRef, ProjectId, ThreadId, TurnId } from "@t3tools/contracts";
import { Effect, Layer, Option } from "effect";
import {
CheckpointRef,
DEFAULT_PROVIDER_INTERACTION_MODE,
ProjectId,
ThreadId,
TurnId,
type OrchestrationReadModel,
} from "@t3tools/contracts";
import { Effect, Layer } from "effect";
import { describe, expect, it } from "vitest";

import {
ProjectionSnapshotQuery,
type ProjectionThreadCheckpointContext,
} from "../../orchestration/Services/ProjectionSnapshotQuery.ts";
import { ProjectionSnapshotQuery } from "../../orchestration/Services/ProjectionSnapshotQuery.ts";
import { checkpointRefForThreadTurn } from "../Utils.ts";
import { CheckpointDiffQueryLive } from "./CheckpointDiffQuery.ts";
import { CheckpointStore, type CheckpointStoreShape } from "../Services/CheckpointStore.ts";
import { CheckpointDiffQuery } from "../Services/CheckpointDiffQuery.ts";

function makeThreadCheckpointContext(input: {
function makeSnapshot(input: {
readonly projectId: ProjectId;
readonly threadId: ThreadId;
readonly workspaceRoot: string;
readonly worktreePath: string | null;
readonly checkpointTurnCount: number;
readonly checkpointRef: CheckpointRef;
}): ProjectionThreadCheckpointContext {
}): OrchestrationReadModel {
return {
threadId: input.threadId,
projectId: input.projectId,
workspaceRoot: input.workspaceRoot,
worktreePath: input.worktreePath,
checkpoints: [
snapshotSequence: 0,
updatedAt: "2026-01-01T00:00:00.000Z",
projects: [
{
id: input.projectId,
title: "Project",
workspaceRoot: input.workspaceRoot,
defaultModelSelection: null,
scripts: [],
createdAt: "2026-01-01T00:00:00.000Z",
updatedAt: "2026-01-01T00:00:00.000Z",
deletedAt: null,
},
],
threads: [
{
turnId: TurnId.makeUnsafe("turn-1"),
checkpointTurnCount: input.checkpointTurnCount,
checkpointRef: input.checkpointRef,
status: "ready",
files: [],
assistantMessageId: null,
completedAt: "2026-01-01T00:00:00.000Z",
id: input.threadId,
projectId: input.projectId,
title: "Thread",
modelSelection: {
provider: "codex",
model: "gpt-5-codex",
},
interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
runtimeMode: "full-access",
branch: null,
worktreePath: input.worktreePath,
latestTurn: {
turnId: TurnId.makeUnsafe("turn-1"),
state: "completed",
requestedAt: "2026-01-01T00:00:00.000Z",
startedAt: "2026-01-01T00:00:00.000Z",
completedAt: "2026-01-01T00:00:00.000Z",
assistantMessageId: null,
},
createdAt: "2026-01-01T00:00:00.000Z",
updatedAt: "2026-01-01T00:00:00.000Z",
deletedAt: null,
handoff: null,
messages: [],
activities: [],
proposedPlans: [],
checkpoints: [
{
turnId: TurnId.makeUnsafe("turn-1"),
checkpointTurnCount: input.checkpointTurnCount,
checkpointRef: input.checkpointRef,
status: "ready",
files: [],
assistantMessageId: null,
completedAt: "2026-01-01T00:00:00.000Z",
},
],
session: null,
},
],
};
Expand All @@ -50,7 +95,7 @@ describe("CheckpointDiffQueryLive", () => {
readonly cwd: string;
}> = [];

const threadCheckpointContext = makeThreadCheckpointContext({
const snapshot = makeSnapshot({
projectId,
threadId,
workspaceRoot: "/tmp/workspace",
Expand Down Expand Up @@ -80,12 +125,7 @@ describe("CheckpointDiffQueryLive", () => {
Layer.provideMerge(Layer.succeed(CheckpointStore, checkpointStore)),
Layer.provideMerge(
Copy link
Copy Markdown
Contributor

@macroscopeapp macroscopeapp bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low Layers/CheckpointDiffQuery.test.ts:126

The test mocks ProjectionSnapshotQuery with only getSnapshot, but CheckpointDiffQueryLive calls getThreadCheckpointContext. At runtime this throws because the method is undefined on the mock. Add getThreadCheckpointContext to the mock and have it return the thread context from getSnapshot.

🤖 Copy this AI Prompt to have your agent fix this: 
In file apps/server/src/checkpointing/Layers/CheckpointDiffQuery.test.ts around line 126:

The test mocks `ProjectionSnapshotQuery` with only `getSnapshot`, but `CheckpointDiffQueryLive` calls `getThreadCheckpointContext`. At runtime this throws because the method is undefined on the mock. Add `getThreadCheckpointContext` to the mock and have it return the thread context from `getSnapshot`.

Evidence trail:
- apps/server/src/checkpointing/Layers/CheckpointDiffQuery.test.ts lines 126-129: Mock only provides `getSnapshot`
- apps/server/src/checkpointing/Layers/CheckpointDiffQuery.test.ts lines 140-143: Test calls getTurnDiff with fromTurnCount: 0, toTurnCount: 1
- apps/server/src/checkpointing/Layers/CheckpointDiffQuery.ts lines 27-28: Early return only when fromTurnCount === toTurnCount
- apps/server/src/checkpointing/Layers/CheckpointDiffQuery.ts line 44: Calls `projectionSnapshotQuery.getThreadCheckpointContext()`
- apps/server/src/orchestration/Services/ProjectionSnapshotQuery.ts lines 63-66: `getThreadCheckpointContext` is part of the interface

Layer.succeed(ProjectionSnapshotQuery, {
getSnapshot: () =>
Effect.die("CheckpointDiffQuery should not request the full orchestration snapshot"),
getCounts: () => Effect.succeed({ projectCount: 0, threadCount: 0 }),
getActiveProjectByWorkspaceRoot: () => Effect.succeed(Option.none()),
getFirstActiveThreadIdByProjectId: () => Effect.succeed(Option.none()),
getThreadCheckpointContext: () => Effect.succeed(Option.some(threadCheckpointContext)),
getSnapshot: () => Effect.succeed(snapshot),
}),
),
);
Expand Down Expand Up @@ -135,11 +175,12 @@ describe("CheckpointDiffQueryLive", () => {
Layer.provideMerge(
Layer.succeed(ProjectionSnapshotQuery, {
getSnapshot: () =>
Effect.die("CheckpointDiffQuery should not request the full orchestration snapshot"),
getCounts: () => Effect.succeed({ projectCount: 0, threadCount: 0 }),
getActiveProjectByWorkspaceRoot: () => Effect.succeed(Option.none()),
getFirstActiveThreadIdByProjectId: () => Effect.succeed(Option.none()),
getThreadCheckpointContext: () => Effect.succeed(Option.none()),
Effect.succeed({
snapshotSequence: 0,
projects: [],
threads: [],
updatedAt: "2026-01-01T00:00:00.000Z",
} satisfies OrchestrationReadModel),
}),
),
);
Expand Down
Loading
Loading