Skip to content

Feat: Discord Threads support#6

Merged
pinmacaroon merged 5 commits into
pinmacaroon:masterfrom
OmegaSunkey:master
May 16, 2026
Merged

Feat: Discord Threads support#6
pinmacaroon merged 5 commits into
pinmacaroon:masterfrom
OmegaSunkey:master

Conversation

@OmegaSunkey
Copy link
Copy Markdown
Contributor

While you can add thread support directly on the webhook by putting in the "?thread_id=" param in the URL, the integrated bot does not recognize it, and only posts on the main channel.

This PR adds thread support for the bot and webhook without touching "?thread_id=" inside config.

Added:
webhook.thread: Boolean = false
webhook.thread.id: String = 01234567890123456789

@OmegaSunkey
Copy link
Copy Markdown
Contributor Author

for some reason it doesnt work even though config sets uri correctly so eh

@OmegaSunkey OmegaSunkey marked this pull request as draft April 17, 2026 05:35
@OmegaSunkey OmegaSunkey marked this pull request as ready for review April 17, 2026 06:08
@OmegaSunkey
Copy link
Copy Markdown
Contributor Author

it work now :D

import java.net.http.HttpResponse;
import java.text.MessageFormat;
import java.util.HashMap;
import java.util.ArrayList;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this is part of another PR

@secp192k1
Copy link
Copy Markdown

Top 10 most entertaining PR's of all time

@pinmacaroon
Copy link
Copy Markdown
Owner

pinmacaroon commented May 3, 2026

hello, sorry for sleeping on this project and ignoring my github stuff. life has been busy.

first things first, im really thankful for this pr, i didnt even think of threads all this time i have been developing this (almost a year wow). it warms my heart to see people actually give a damn about the stuff i make.

second, did you use any gen ai (claude or copilot or any other LLM)? i do not support coding with the use of ai, and i want to keep my projects 100% human made. if ANY ai was used, i would sadly have to reject this pr.

anyhow, this is a good pr and a good fix for my oversight 🫶

PS: why is every file in a different commit lmao

@pinmacaroon pinmacaroon self-assigned this May 3, 2026
@pinmacaroon pinmacaroon added the enhancement New feature or request label May 3, 2026
@OmegaSunkey
Copy link
Copy Markdown
Contributor Author

hello, didn't notice this comment before, should have been in my e-mail...

no I didn't use any LLMs to create this, all code was done by me by looking at your code :D
I found this mod in modrinth and really liked it, and saw it could have some features like threads.
PS: put them in diff commits to revert changes easily -w-. You can squash them if you wish.

@pinmacaroon
Copy link
Copy Markdown
Owner

heyo, thanks for your response! i will most definitely merge this pr as soon as i get home.

also, its great knowing my code is not too messy to work with, i may have some bad practices during code formatting and stuff :P

if you want to, i can credit you in the modrinth readme and the mod's credits as a contributor (will figure out how to do that, i havent touched that in a loooong time)

@OmegaSunkey
Copy link
Copy Markdown
Contributor Author

If anything the code was easy to understand !

If you wish to do so, you can attribute yea .w.

@pinmacaroon pinmacaroon merged commit 53b645a into pinmacaroon:master May 16, 2026
1 check passed
@pinmacaroon
Copy link
Copy Markdown
Owner

forgot to squash god damn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants