Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/fetch-scripts.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ set -eu
SCRIPT_PATH="$(realpath "$(dirname "$0")")"
GOASSETS_PATH="${SCRIPT_PATH}/.goassets"

GOASSETS_REF=${GOASSETS_REF:-master}
GOASSETS_REF=${GOASSETS_REF:-main}

if [ -d "${GOASSETS_PATH}" ]; then
if ! git -C "${GOASSETS_PATH}" diff --exit-code; then
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ on:

jobs:
check:
uses: pion/.goassets/.github/workflows/api.reusable.yml@master
uses: pion/.goassets/.github/workflows/api.reusable.yml@main
4 changes: 2 additions & 2 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ on:
- cron: '23 5 * * 0'
pull_request:
branches:
- master
- main
paths:
- '**.go'

jobs:
analyze:
uses: pion/.goassets/.github/workflows/codeql-analysis.reusable.yml@master
uses: pion/.goassets/.github/workflows/codeql-analysis.reusable.yml@main
4 changes: 2 additions & 2 deletions .github/workflows/fuzz.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ name: Fuzz
on:
push:
branches:
- master
- main
schedule:
- cron: "0 */8 * * *"

jobs:
fuzz:
uses: pion/.goassets/.github/workflows/fuzz.reusable.yml@master
uses: pion/.goassets/.github/workflows/fuzz.reusable.yml@main
with:
go-version: "1.25" # auto-update/latest-go-version
fuzz-time: "60s"
4 changes: 3 additions & 1 deletion .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,6 @@ on:

jobs:
lint:
uses: pion/.goassets/.github/workflows/lint.reusable.yml@master
uses: pion/.goassets/.github/workflows/lint.reusable.yml@main
with:
golangci-lint-version: v2.10.1
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ on:

jobs:
release:
uses: pion/.goassets/.github/workflows/release.reusable.yml@master
uses: pion/.goassets/.github/workflows/release.reusable.yml@main
with:
go-version: "1.25" # auto-update/latest-go-version
2 changes: 1 addition & 1 deletion .github/workflows/renovate-go-sum-fix.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ on:

jobs:
fix:
uses: pion/.goassets/.github/workflows/renovate-go-sum-fix.reusable.yml@master
uses: pion/.goassets/.github/workflows/renovate-go-sum-fix.reusable.yml@main
secrets:
token: ${{ secrets.PIONBOT_PRIVATE_KEY }}
2 changes: 1 addition & 1 deletion .github/workflows/reuse.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ on:

jobs:
lint:
uses: pion/.goassets/.github/workflows/reuse.reusable.yml@master
uses: pion/.goassets/.github/workflows/reuse.reusable.yml@main
12 changes: 6 additions & 6 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ name: Test
on:
push:
branches:
- master
- main
pull_request:

jobs:
test:
uses: pion/.goassets/.github/workflows/test.reusable.yml@master
uses: pion/.goassets/.github/workflows/test.reusable.yml@main
strategy:
matrix:
go: ["1.25", "1.24"] # auto-update/supported-go-version-list
Expand All @@ -30,7 +30,7 @@ jobs:
secrets: inherit

test-i386:
uses: pion/.goassets/.github/workflows/test-i386.reusable.yml@master
uses: pion/.goassets/.github/workflows/test-i386.reusable.yml@main
strategy:
matrix:
go: ["1.25", "1.24"] # auto-update/supported-go-version-list
Expand All @@ -39,7 +39,7 @@ jobs:
go-version: ${{ matrix.go }}

test-windows:
uses: pion/.goassets/.github/workflows/test-windows.reusable.yml@master
uses: pion/.goassets/.github/workflows/test-windows.reusable.yml@main
strategy:
matrix:
go: ["1.25", "1.24"] # auto-update/supported-go-version-list
Expand All @@ -48,7 +48,7 @@ jobs:
go-version: ${{ matrix.go }}

test-macos:
uses: pion/.goassets/.github/workflows/test-macos.reusable.yml@master
uses: pion/.goassets/.github/workflows/test-macos.reusable.yml@main
strategy:
matrix:
go: ["1.25", "1.24"] # auto-update/supported-go-version-list
Expand All @@ -57,7 +57,7 @@ jobs:
go-version: ${{ matrix.go }}

test-wasm:
uses: pion/.goassets/.github/workflows/test-wasm.reusable.yml@master
uses: pion/.goassets/.github/workflows/test-wasm.reusable.yml@main
with:
go-version: "1.25" # auto-update/latest-go-version
secrets: inherit
4 changes: 2 additions & 2 deletions .github/workflows/tidy-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ on:
pull_request:
push:
branches:
- master
- main

jobs:
tidy:
uses: pion/.goassets/.github/workflows/tidy-check.reusable.yml@master
uses: pion/.goassets/.github/workflows/tidy-check.reusable.yml@main
with:
go-version: "1.25" # auto-update/latest-go-version
4 changes: 4 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ linters:
- maintidx # maintidx measures the maintainability index of each function.
- makezero # Finds slice declarations with non-zero initial length
- misspell # Finds commonly misspelled English words in comments
- modernize # Replace and suggests simplifications to code
- nakedret # Finds naked returns in functions greater than a specified function length
- nestif # Reports deeply nested if statements
- nilerr # Finds the code that returns nil even if it checks that the error is not nil.
Expand Down Expand Up @@ -145,3 +146,6 @@ formatters:
- goimports # Goimports does everything that gofmt does. Additionally it checks unused imports
exclusions:
generated: lax
issues:
max-issues-per-linter: 0
max-same-issues: 0
2 changes: 1 addition & 1 deletion unmarshal.go
Original file line number Diff line number Diff line change
Expand Up @@ -877,7 +877,7 @@ func unmarshalMediaDescription(lex *lexer) (stateFn, error) { //nolint:cyclop
// Set according to currently registered with IANA
// https://tools.ietf.org/html/rfc4566#section-5.14
// https://tools.ietf.org/html/rfc4975#section-8.1
for _, proto := range strings.Split(field, "/") {
for proto := range strings.SplitSeq(field, "/") {
if !anyOf(
proto,
"UDP",
Expand Down
1 change: 0 additions & 1 deletion unmarshal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,6 @@ func TestRoundTrip(t *testing.T) {
SDP: MediaFECSDP,
},
} {
test := test
t.Run(test.Name, func(t *testing.T) {
sd := &SessionDescription{}

Expand Down
2 changes: 1 addition & 1 deletion util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ func TestGetCodecsForPayloadTypes(t *testing.T) {
func TestNewSessionID(t *testing.T) {
minVal := uint64(0x7FFFFFFFFFFFFFFF)
maxVal := uint64(0)
for i := 0; i < 10000; i++ {
for range 10000 {
r, err := newSessionID()
assert.NoError(t, err)
assert.Lessf(t, r, uint64((1<<64)-1), "Session ID must be less than 2**64-1, got %d", r)
Expand Down
Loading