Add 'Do not show again' checkbox to lint confirmation modals#1475
Add 'Do not show again' checkbox to lint confirmation modals#1475pjkaufman merged 9 commits intoplaters:masterfrom
Conversation
This allows the lint-all-files command to run without the confirmation dialog, making it usable from the Obsidian CLI and other automation tools. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds translated strings for de, es, ja, ru, tr, and zh-cn locales. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rename suppressLintAllFilesConfirmationModal to suppressLintConfirmationModal so a single toggle suppresses the confirmation modal for both "lint all files" and "lint all files in folder" commands. This makes the folder lint command headless/CLI-friendly as well. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
I would prefer this be a "do not show again" checkbox on both the folder and lint all modals. It would get stored in the |
|
Going through the CLI will need to be handled via a CLI handler or what have you in order to prevent even asking for the UI confirmation. But that will have to come separately. |
|
@pjkaufman updated PR. |
Move the suppress-confirmation preference from a standalone General settings toggle into a checkbox rendered directly on the lint confirmation modals. More discoverable and follows common UI patterns. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Sorry about the delay. I will go ahead and take a look and see how things look and function. |
|
My main concern from just looking at the code is that the code uses the same logic to suppress both modals. But that may not be the intent. I would expect each modal to have its own setting for suppressing seeing it. That hopefully would not be too bad to implement. But I will look at the actual way in which it works in the app. |
|
Edit: operator error here. I needed to swap to the branch and check. It looks like both modals do indeed use the same setting, so that would need changing. I can see wanting to suppress the modal for folder lints, but not the lint all functionality as well. |
|
I can attest to the logic working. So it just needs to use one boolean for each of the actual modals (folder and all files). |
pjkaufman
left a comment
There was a problem hiding this comment.
Looks and seems to work good except for one checkbox being used for both modals. If we can get that swapped over to two settings instead of one, this should be good for merging.
Split suppressLintConfirmationModal into suppressLintAllFilesConfirmationModal and suppressLintAllFilesInFolderConfirmationModal so each modal can be independently dismissed. Includes migration for existing data.json values.
|
Split the single
Each modal's "Do not show again" checkbox now only affects that specific modal. Added migration in |
|
this is a useful change for agentic workflows. let's get this merged |
pjkaufman
left a comment
There was a problem hiding this comment.
Looks good now that I removed the logic around migrating a setting that does not exist.
Summary
lint-all-filesandlint-all-files-in-folder)data.jsonso future invocations skip the modalMotivation
Closes #1474
The confirmation modals block automation workflows — running these commands via Obsidian CLI, MCP, or other programmatic invocations shows a dialog that can't be dismissed without user interaction.
Rather than a standalone settings toggle, the preference is set directly from the modal via a "Do not show again" checkbox, which is more discoverable and follows common UI patterns.
Test plan
saveSuppressPreferencecallback not provided🤖 Generated with Claude Code