Skip to content

[WIP] Review ChromeCdpSnapshotService implementation#371

Draft
Copilot wants to merge 1 commit intomasterfrom
copilot/review-chrome-cdp-snapshot-service
Draft

[WIP] Review ChromeCdpSnapshotService implementation#371
Copilot wants to merge 1 commit intomasterfrom
copilot/review-chrome-cdp-snapshot-service

Conversation

Copy link
Contributor

Copilot AI commented Mar 8, 2026

  • Remove dead code: unused private method computeVisibility in ChromeCdpDomService (duplicate of visibilityStyleCheck local function and calculateVisibility)
  • Remove dead code: unused private method computeInteractivity in ChromeCdpDomService (duplicate of calculateInteractivity)
  • Remove dead code: unused private method calculateVisibility in ChromeCdpDomService (the merge function uses visibilityStyleCheck + isElementVisibleAccordingToAllParents instead)
  • Hoist HighlightManager to a lazy class-level property instead of creating a new instance in each highlight method
  • Hoist ClickableElementDetector to a class-level property instead of creating a new instance in calculateInteractivity
  • Rename calculateScalabilitycalculateScrollability to match its purpose and the isScrollable field it populates
  • Build and test changes
  • Run code review
  • Run CodeQL

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants