Add MCPToolController and fix 5 failing MCPToolControllerE2ETest cases#374
Draft
Add MCPToolController and fix 5 failing MCPToolControllerE2ETest cases#374
Conversation
Co-authored-by: galaxyeye <1701451+galaxyeye@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bugs in MCPToolControllerE2ETest cases
Add MCPToolController and fix 5 failing MCPToolControllerE2ETest cases
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCPToolControllerandMCPToolControllerE2ETestwere absent from the codebase despite being referenced. The controller also had incorrect WebDriver method names (navigate→navigateTo,screenshot→captureScreenshot) and used several non-existent WebDriver methods.Changes
SessionManager.ktgetAllSessions(): List<ManagedSession>anddeleteAllSessions(): Intrequired by the controller's list/close-all/kill-all session handlersMCPToolController.kt(new)POST /mcp/call-tool— routes session-management tools (open_session,close_session,list_sessions,close_all_sessions,kill_all_sessions,delete_session_data) directly, dispatches all other tools to the session's WebDriverGET /mcp/tools— returns the full tool list consumed by browser4-clinavigateTo,captureScreenshotdblclick,select_option,dialog_accept,dialog_dismiss,resize,keydown,keyup,mousedown,mouseup) viadriver.evaluate()ObjectMapperin companion object (shared);errorResponsesetsisError = truewith the raw messageMCPToolControllerE2ETest.kt(new)@Tag("E2ETest")tests covering all browser4-cli→MCP tool mappings📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.