-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Tracker] Use ResizeObserver instead of polling for document height #6174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+39
−26
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
82441fb
Use ResizeObserver instead of polling for document height
ukutaht 3c8c5e7
fix: avoid forced reflow in getCurrentScrollDepthPx
ukutaht 6579f68
disable engagement tracking in compat mode
ukutaht e4e4870
Add changelog entry
ukutaht 663bd23
Bump tracker script version
ukutaht d883d1d
Add COMPAT fallback for engagement tracking
ukutaht 215006f
Fix lint
ukutaht 7681b90
Fix formatting issues
ukutaht 7d1b6d0
fix: use hkps keyserver to avoid blocked port 80 in CI
ukutaht c6390cf
fix: fetch ClickHouse key via curl instead of keyserver
ukutaht 4fb22a7
chore: print PR labels in workflow for debugging
ukutaht 04360c8
Revert "chore: print PR labels in workflow for debugging"
ukutaht c3560ef
Add tracker script changelog entry
ukutaht File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "tracker_script_version": 33, | ||
| "tracker_script_version": 34, | ||
| "type": "module", | ||
| "scripts": { | ||
| "lint": "eslint", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By removing IE support for engagement tracking, these fallbacks are not necessary since
window.scrollYandwindow.innerHeightare well-supported:https://caniuse.com/mdn-api_window_innerheight
https://caniuse.com/mdn-api_window_scrolly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion, non-blocking: Can we keep 0 fallback? It doesn't cost much weight-wise and then the math won't crash entirely if for some reason these values are not truthy. Positive numbers are truthy.