Skip to content

Fix Elixir 1.20 warnings #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hkrutzer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Elixir 1.20 warnings #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/ecto/adapters/clickhouse/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ defmodule Ecto.Adapters.ClickHouse.Connection do
@behaviour Ecto.Adapters.SQL.Connection
@dialyzer :no_improper_lists

require Logger
alias Ecto.SubQuery
alias Ecto.Query.{QueryExpr, ByExpr, JoinExpr, BooleanExpr, WithExpr, Tagged}

Expand Down
4 changes: 2 additions & 2 deletions lib/mix/tasks/schema.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ defmodule Mix.Tasks.Ecto.Ch.Schema do
IO.puts(@moduledoc)
end

def run(["-" <> _k | _] = kvs) do
run(_source = nil, kvs)
def run(["-" <> _k | _]) do
run([])
Copy link
Copy Markdown
Collaborator

@ruslandoga ruslandoga Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would just print the help message? I'll be able to actually test it tomorrow.

end

def run([source | kvs]) do
Expand Down
Loading