Conversation
Comment on lines
+59
to
+64
| "color": { | ||
| "r": 0, | ||
| "g": 0, | ||
| "b": 0, | ||
| "a": 1 | ||
| } |
Contributor
There was a problem hiding this comment.
Doesn't a sensible default get used if a value is left unspecified? Without that, I think the system's going to be very brittle!
Contributor
Author
There was a problem hiding this comment.
The sensible defaults are defined in the script itself, but we override the whole top-level vignette property when we pass a partial object. That replaces the default Vignette instance, so nested defaults like vignette.color are lost. @playcanvas/react currently only does top-level script prop assignment; it doesn’t do nested merging for script config objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Had to add a
colorfield to thevignettedue to the recent engine change: playcanvas/engine#8318I confirm I have read the contributing guidelines.