fix: event listener leak on outerConeAngle in light component inspector#1904
Open
willeastcott wants to merge 1 commit intomainfrom
Open
fix: event listener leak on outerConeAngle in light component inspector#1904willeastcott wants to merge 1 commit intomainfrom
willeastcott wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an event-listener accumulation issue in the Light component inspector by ensuring the outerConeAngle change handler is subscribed exactly once per inspector instance (instead of being re-registered on every _toggleFields() call).
Changes:
- Register
outerConeAngle→_resetInnerConeAngleLimit()change listener in the constructor (one-time). - Remove the repeated listener registration from
_toggleFields()while keeping the immediate limit refresh behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outerConeAnglechange handler (_resetInnerConeAngleLimit) was being registered inside_toggleFields(), which runs on everylink()call and on every change to any of the 10 toggle-driving fields. This caused unbounded listener accumulation over repeated link/unlink cycles. Moved the subscription to the constructor so it is registered exactly once.Test plan