fix: prevent builds dialog from closing when using dropdown menu#1970
Merged
willeastcott merged 1 commit intomainfrom Mar 20, 2026
Merged
fix: prevent builds dialog from closing when using dropdown menu#1970willeastcott merged 1 commit intomainfrom
willeastcott merged 1 commit intomainfrom
Conversation
Fixed #1969 Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a UI regression where interacting with the builds dropdown / delete confirmation could unintentionally dismiss the “Project” builds dialog, by aligning the builds dropdown with existing PCUI overlay/menu click-guard behavior and tightening overlay dismissal rules.
Changes:
- Migrates the builds “…” dropdown from
LegacyMenuto PCUIMenuso it is recognized by the existing.pcui-menupointerdown guard. - Updates the project overlay pointerdown handling to avoid closing when the user clicks inside a different overlay (e.g. confirmation modal).
- Adds SCSS rules to hide the empty submenu children container on hover for leaf menu items in the builds and scene dropdown menus.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/editor/pickers/picker-project.ts |
Prevents the project overlay from closing when pointer events originate from a different .pcui-overlay. |
src/editor/pickers/picker-builds-publish.ts |
Replaces LegacyMenu with PCUI Menu for the builds dropdown, using hidden/show/hide semantics consistent with other PCUI menus. |
sass/editor/_editor-main.scss |
Adds menu styling to hide empty submenu containers for leaf items in builds/scene menus. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LegacyMenuto PCUIMenu, so the project overlay's existing.pcui-menupointerdown guard recognizes it and no longer dismisses the builds dialog when the dropdown is openFixes #1969