Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix SPZ v3 import parsing by handling the v3 rotation payload correctly and adding regression coverage.
What changed
preparescript so git-based installs builddist/, which lets the stackedsupersplatfollow-up consume this branch before an npm release existsRoot cause
The current v3 reader had three issues:
That combination made v3 rotation data decode incorrectly.
Validation
npm run buildnpm run lintsupersplatvalidation also succeeds when pointed at this patched package and loading a real v3 fileFollow-up
There is a stacked
supersplatPR that pins this branch commit temporarily so SPZ v3 support can be reviewed end-to-end before the npm package release. The expectation is to merge this PR first, then replace that temporary git pin with the published package version before merging the consumer PR.Notes
FYI, I did not include SPZ v4 support here (which we're planning on releasing soon). This change is scoped to making the existing v3 support to work proprely.