Skip to content

Schema Validation and Related XLR Fixes#242

Merged
KetanReddy merged 22 commits intomainfrom
schema-validation-and-generic-fixes
Mar 13, 2026
Merged

Schema Validation and Related XLR Fixes#242
KetanReddy merged 22 commits intomainfrom
schema-validation-and-generic-fixes

Conversation

@KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Feb 25, 2026

  • patch
  • minor
  • major

Release Notes

  • XLR: Pull in Fix additionalProperties in XLR types #240
  • XLR Fix issue with local generics not being honored during SDK recall of type leading to improper generic resolution
  • XLR: Fix issue where top level variable exports that were in the custom primitives list were fully evaluated
  • XLR: Support types exported under namespaces as part of type export
  • XLR/CLI: Fix issue with cross namespace collisions for type exports and variable names with plugin exports
  • Language: Support validation of schema section of Player content
  • Validator: Don't escape properties containing dashes with quotes as that is no longer behavior that XLR has.
📦 Published PR as canary version: 0.13.0--canary.242.6203

Try this version out locally by upgrading relevant packages to 0.13.0--canary.242.6203

@KetanReddy KetanReddy added the minor Increment the minor version when merged label Feb 25, 2026
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 84.82490% with 78 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.46%. Comparing base (1fcbdff) to head (7eeed52).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...ge-service/src/plugins/schema-validation-plugin.ts 88.27% 50 Missing and 1 partial ⚠️
cli/src/utils/xlr/visitors/plugin.ts 0.00% 10 Missing ⚠️
xlr/converters/src/ts-to-xlr.ts 80.00% 8 Missing and 1 partial ⚠️
language/json-language-service/src/utils.ts 76.92% 3 Missing ⚠️
cli/src/commands/xlr/compile.ts 0.00% 2 Missing ⚠️
cli/src/utils/xlr/consts.ts 0.00% 2 Missing ⚠️
language/json-language-service/src/xlr/registry.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   68.72%   69.46%   +0.73%     
==========================================
  Files         156      157       +1     
  Lines       13660    14147     +487     
  Branches     2053     2138      +85     
==========================================
+ Hits         9388     9827     +439     
- Misses       4249     4296      +47     
- Partials       23       24       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KetanReddy
Copy link
Member Author

/canary

@KetanReddy KetanReddy force-pushed the schema-validation-and-generic-fixes branch 6 times, most recently from c8ebdbf to bcb9b51 Compare February 27, 2026 23:25
@KetanReddy
Copy link
Member Author

/canary

@KetanReddy KetanReddy changed the title Schema validation and XLR Generic Handling Fixes Schema Validation and Related XLR Fixes Feb 28, 2026
@KetanReddy
Copy link
Member Author

/canary

4 similar comments
@KetanReddy
Copy link
Member Author

/canary

@KetanReddy
Copy link
Member Author

/canary

@KetanReddy
Copy link
Member Author

/canary

@KetanReddy
Copy link
Member Author

/canary

@KetanReddy KetanReddy force-pushed the schema-validation-and-generic-fixes branch from c7dd6dc to 8eb3e88 Compare March 12, 2026 21:40
@KetanReddy KetanReddy marked this pull request as ready for review March 12, 2026 22:17
@KetanReddy KetanReddy requested a review from a team as a code owner March 12, 2026 22:17
rafbcampos
rafbcampos previously approved these changes Mar 13, 2026
@KetanReddy KetanReddy force-pushed the schema-validation-and-generic-fixes branch from dc868a1 to d04716e Compare March 13, 2026 20:56
@KetanReddy KetanReddy dismissed rafbcampos’s stale review March 13, 2026 20:57

The merge-base changed after approval.

@KetanReddy KetanReddy merged commit e94425a into main Mar 13, 2026
6 checks passed
@KetanReddy KetanReddy deleted the schema-validation-and-generic-fixes branch March 13, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Increment the minor version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants