refactor: sequential type indices in bytecode#208
Merged
Conversation
Changes type system so builtins and custom types share a sequential pool of indices. Builtins (Void, Node, String) are emitted first if used, then custom types follow - no reserved slots for unused builtins. Key changes: - Add Void, Node, String variants to TypeKind enum - Remove QTypeId::VOID/NODE/STRING constants and is_builtin() method - Update TypeTableBuilder to emit builtins as TypeDefs when referenced - Update bytecode dump to use dynamic index width formatting - Update TypeScript emitter to use TypeKind checks instead of constants This eliminates index gaps in bytecode (e.g., T0, T1, T3 → T0, T1, T2).
zharinov
force-pushed
the
refactor/sequential-type-indices
branch
from
bc8fa74 to
46ba176
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
T0, T1, T3→T0, T1, T2)Test plan