fix(engine): labeled alternation with definition reference#231
Merged
fix(engine): labeled alternation with definition reference#231
Conversation
72e0c73 to
f8cb0d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$data: {}$data: { name: Node }, but runtime materialization discarded the valueProblem
When a labeled alternation variant references a named definition containing captures:
The
$datafield was empty{}instead of containing{ name: Node }.Root Cause
In
materializer.rs,EndEnumwas discarding any pending value from an inner definition'sObj/EndObjand constructing$datafrom the emptyfieldsvector.Fix
Modified
EndEnumto consume the pending value if available:Test plan
alternations_tagged_with_definition_ref