fix: implement call-site scoping for captured refs#259
Merged
Conversation
zharinov
force-pushed
the
fix/call-site-scoping
branch
5 times, most recently
from
4057723 to
49f75b2
Compare
- Definitions are normalized (no Obj/EndObj wrapper) - Call sites decide scoping based on capture and return type - Universal preamble wraps every entrypoint: Obj → Trampoline → EndObj → Return - Layout starts at address 0 (preamble is first instruction) - StepId now uses u16 (0 is valid address, terminal handled by decoding logic)
zharinov
force-pushed
the
fix/call-site-scoping
branch
from
49f75b2 to
7c38b8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trampolinebytecode instruction for universal entry preambleObj/EndObjfrom definitions to call sites (call-site scoping)Obj → Trampoline → EndObj → ReturnEndObjmaterializer to preserve pending values for non-struct resultsWhy
Fixes Bug 3: mixed captured/uncaptured sibling refs were losing data at runtime.
Before:
A = (program (B) @b (C))produced{b: {x: ...}}—yfrom C was missing.After: produces
{b: {x: ...}, y: ...}— both captured and uncaptured refs work correctly.The root cause was that definitions decided whether to wrap with
Obj/EndObjbased on their own captures, but the correct behavior depends on how the definition is called:(B) @b→ needs isolated scope(B)→ captures should bubble to parentNotes
has_direct_captureslogic from PR fix: skipObj/EndObjfor definitions without direct captures #257 (now removed)