fix: empty captured sequences produce empty struct instead of null#272
Merged
fix: empty captured sequences produce empty struct instead of null#272
Conversation
5464082 to
75718bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ }) as producing empty struct type, not NodeObj/EndObjwrapper for empty captured sequences{}) from root-level (preamble →null)Why
Queries like
{ } @xand{ }? @maybewere either panicking with type mismatch or producing incorrectnullvalues. Empty sequences should produce empty struct{}when captured.Notes
Added
is_truly_empty_scope()helper inparser/ast.rsto distinguish truly empty sequences ({ }) from sequences with void flow due to suppression ({(expr) @_}). The latter should still capture the matched node, not produce an empty struct.