Conversation
zharinov
changed the title
zharinov
force-pushed
the
feat/cache-line-alignment
branch
from
390aea4 to
26ed3fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
size >= 48guard from layout algorithm — now ALL instructions get cache-line alignedSymbol::PADDINGconstant and show padding steps as07 ...in dump outputWhy
Previously only large instructions (Match48+) got cache line alignment. This caused smaller instructions to straddle 64-byte cache line boundaries, potentially hurting performance. Now the invariant is enforced with an assert.
The padding visualization helps debug layout issues by making padding slots visible in dumps.