Skip to content

Fix/skip rules param #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Herafia wants to merge 3 commits into
base: 10.0/bugfixes
Choose a base branch
from
Open

Fix/skip rules param #425

Herafia wants to merge 3 commits into from

Conversation

@Herafia
Copy link
Contributor

@Herafia Herafia commented Jan 27, 2026

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !41373
  • respect _skip_rules to skip business rules

Screenshots (if appropriate):

@Herafia Herafia requested review from Rom1-B and stonebuzz January 27, 2026 16:25
@stonebuzz stonebuzz changed the base branch from main to 10.0/bugfixes January 27, 2026 16:39
Rom1-B
Rom1-B requested changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests

@Herafia Herafia self-assigned this Jan 28, 2026
@Herafia
Copy link
Contributor Author

Herafia commented Jan 28, 2026

wait glpi-project/glpi#22871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rom1-B Rom1-B Rom1-B requested changes

@stonebuzz stonebuzz Awaiting requested review from stonebuzz

Requested changes must be addressed to merge this pull request.

Assignees

@Herafia Herafia

Labels

Need unit tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Herafia @Rom1-B