Skip to content

Fix/skip rules param #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Herafia wants to merge 3 commits into
base: 10.0/bugfixes
Choose a base branch
from
Open

Fix/skip rules param #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0e3b8f
add param skip rules
Herafia Jan 27, 2026
555d7fa
CHANGELOG
Herafia Jan 27, 2026
6934fbf
tests
Herafia Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Handle mandatory template fields in history button escalation
- Fix `tag` deletion before escalation using `Escalate button`
- Fix `label` button color
- Add param skip_rules

## [2.9.18] - 2025-30-09

Expand Down
8 changes: 6 additions & 2 deletions inc/ticket.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public static function pre_item_update(CommonDBTM $item)
}

$input = $item->input;
if ($item instanceof CommonITILObject) {
if ($item instanceof Ticket) {
// Special handling for history button escalation to pass template validation
if (isset($item->input['_no_escalade_template_validation'])) {
// Add existing ticket fields temporarily for template validation
Expand Down Expand Up @@ -127,10 +127,14 @@ public static function pre_item_update(CommonDBTM $item)
}

$temp_input['_disablenotif'] = true; // Disable notifications for this validation
$temp_input['_skip_rules'] = true;
$input = $item->prepareInputForUpdate($temp_input);
unset($item->input['_no_escalade_template_validation']); // Clean up flag
} else {
$input = $item->prepareInputForUpdate($item->input);
// Pass the _skip_rules flag via a temporary input array to avoid polluting $item->input
$tmp_input = $item->input;
$tmp_input['_skip_rules'] = true;
$input = $item->prepareInputForUpdate($tmp_input);
}
if (!$input) {
return false;
Expand Down
73 changes: 73 additions & 0 deletions tests/Units/TicketTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1525,4 +1525,77 @@ public function testHistoryButtonEscalationWithMandatoryAssignedGroupField()
$ticket->getFromDB($ticket->getID());
$this->assertEquals($category->getID(), $ticket->fields['itilcategories_id']);
}

public function testRuleCreatesSingleTaskOnCategoryAssign()
{
$this->login();

// Create a task template that will be appended by the rule
$task_template = $this->createItem(\TaskTemplate::class, [
'name' => 'Rule created task template',
'content' => 'Task created by rule',
'is_recursive' => 1,
]);
$this->assertGreaterThan(0, $task_template->getID());

// Create an ITIL category that will trigger the rule
$category = $this->createItem(\ITILCategory::class, [
'name' => 'Category that triggers task rule',
'entities_id' => 0,
'is_recursive' => 1,
]);
$this->assertGreaterThan(0, $category->getID());

// Create a RuleTicket that appends the task template when the category is set
$rule = $this->createItem(\Rule::class, [
'name' => 'Create task on category assign',
'sub_type' => 'RuleTicket',
'match' => 'AND',
'is_active' => 1,
// Trigger on update (could be ONADD | ONUPDATE but update is enough for this test)
'condition' => \RuleTicket::ONUPDATE,
'is_recursive' => 1,
]);
$this->assertGreaterThan(0, $rule->getID());

// Add action to append task template
$this->createItem(\RuleAction::class, [
'rules_id' => $rule->getID(),
'action_type' => 'append',
'field' => 'task_template',
'value' => $task_template->getID(),
]);

// Add criteria: ticket category must be the created category
$this->createItem(\RuleCriteria::class, [
'rules_id' => $rule->getID(),
'criteria' => 'itilcategories_id',
'condition' => \Rule::PATTERN_IS,
'pattern' => $category->getID(),
]);

// Reset rule cache for ticket rules
\SingletonRuleList::getInstance("RuleTicket", 0)->load = 0;
\SingletonRuleList::getInstance("RuleTicket", 0)->list = [];

// Create a ticket without category
$ticket = $this->createItem(\Ticket::class, [
'name' => 'Ticket for rule task creation',
'content' => 'Content',
]);
$this->assertGreaterThan(0, $ticket->getID());

// Ensure there is no task before assigning the category
$ticket_task = new \TicketTask();
$this->assertEquals(0, count($ticket_task->find(['tickets_id' => $ticket->getID()])));

// Update the ticket to set the category - this should trigger the rule
$this->updateItem(\Ticket::class, $ticket->getID(), [
'itilcategories_id' => $category->getID(),
]);

// Verify that exactly one task was created for the ticket
$tasks = $ticket_task->find(['tickets_id' => $ticket->getID()]);
$this->assertEquals(1, count($tasks), 'Exactly one task should be created when assigning the category');
}
}
Loading