fix: pre-filter input source arrays in store and upgrade to zustand v5#469
Open
myers wants to merge 2 commits intopmndrs:mainfrom
Open
fix: pre-filter input source arrays in store and upgrade to zustand v5#469myers wants to merge 2 commits intopmndrs:mainfrom
myers wants to merge 2 commits intopmndrs:mainfrom
Conversation
Filtering input sources by type now happens once in the store when sources change, rather than in components on every render. Returns stable array references.
myers
force-pushed
the
fix/react-19-getsnapshot
branch
from
09a0673 to
4923388
Compare
myers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds pre-filtered arrays to the XR store state:
Filtering now happens once when input sources change (controller connect/disconnect) instead of on every component render, providing stable references for React 19.
Updated both React and vanilla element implementations to use the pre-filtered arrays.
This laid the ground work to upgrade to zustand 5.