feat(evaluation): optional results preview music on clear#469
Draft
adstep wants to merge 2 commits into
Draft
Conversation
Add an EvalPreviewMusic option (Sound submenu, default off) that plays the song's preview music once on the results screen after a clear (silent on fail).
Drop the clear-only guard so the preview plays once on the results screen regardless of pass/fail. Update help text and rename the helper accordingly.
adstep
force-pushed
the
adstep/results-preview-music
branch
from
aa394ce to
3e89e2f
Compare
Contributor
|
Just wondering if this case was accounted for/tested...what is the behavior if user has Custom Sound Packs on the evaluation screen? Do they play at the same time? Would be cursed but also kinda funny |
Contributor
Author
These get layered and run at the same time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The results/evaluation screen is silent after a song ends. Some players prefer a bit of ambiance there. This adds an opt-in setting to play the song's preview snippet once on the results screen, but only after a clear (it stays silent on a fail, matching the somber tone of a failed attempt).
What
EvalPreviewMusicoption under Options > Sound, default Off, persisted to config ([Options]block) alongside the existingMenuMusictoggle.music_rate. Playback is guarded so it only fires on a clear (!all_joined_players_failed) and only once per screen via apreview_music_startedflag.compute_preview_cut, nowpub(crate)) so the cut points and behavior stay consistent with the wheel preview.en.ini(OptionsSoundlabel + help text).