Add quantization and foot-parity evaluation scatterplots (rssp parity)#558
Draft
adstep wants to merge 5 commits into
Draft
Add quantization and foot-parity evaluation scatterplots (rssp parity)#558adstep wants to merge 5 commits into
adstep wants to merge 5 commits into
Conversation
Port Simply Love's by-quantization and by-foot evaluation scatterplots as two new graph panes. Quant colors points by note quantization; FootParity uses real rssp left/right foot parity. ScatterFoot stays in deadsync-rules (rssp-free); parity is computed in the app layer and joined onto scatter points by row_index.
Drop the alternating-feet heuristic Foot pane and its now-dead support code (ScatterPoint.is_stream/is_left_foot, is_stream_beat, the foot alternation in build_scatter_points and its stream_segments param). The rssp-based FootParity pane is now the sole left/right-foot view and inherits the red/blue feet overlay. Graph cycle is now scoring, Arrow, Quant, FootParity.
Show a small bottom-left label naming what the active graph's colors encode (Judgment, Column, Quantization, Foot). The graph cache key already includes the pane, so the label refreshes when cycling graphs.
Drop the "By " prefix so labels read Judgment / Column / Quantization / Foot.
The per-arrow timing-stats pane's left/right-foot buckets now use real rssp foot parity instead of the alternation heuristic. compute_arrow_timing_stats takes an optional per-note parity map (deadsync-rules stays rssp-free; the map is built in the app layer via foot_parity_by_note_for_results), attributing each arrow - including the two halves of a jump - to its actual foot. Alternation remains the fallback for non-4/8-panel charts and rows rssp skips.
adstep
force-pushed
the
adstep/port-quant-foot-scatterplot
branch
from
e9651dd to
925b0e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Simply Love offers evaluation scatterplots colored by note quantization and by left/right foot, which give players useful feedback on rhythm reading and per-foot timing bias. Now that
rsspexposes real step-parity annotations, we can port both, with the foot view backed by actual parity data instead of a guess.What
Adds two new evaluation graph panes and replaces an inaccurate heuristic with real
rsspparity throughout the foot-based displays.EvalGraphPane::Quant): colors each timing point by its note quantization using Simply Love's palette (4th red, 8th blue, 12th purple, 16th green, 24th pink, 32nd yellow, 48th light pink, 64th/192nd teal).EvalGraphPane::FootParity): colors points by realrsspleft/right foot parity (left red, right blue, jumps/unknown black). This replaces the old heuristicFootpane, which alternated feet and blacked out anything not detected as a stream (so a "No Streams" chart rendered entirely black).