Show decimal BPMs to 3 places instead of rounding to nearest tenth#602
Draft
adstep wants to merge 1 commit into
Draft
Show decimal BPMs to 3 places instead of rounding to nearest tenth#602adstep wants to merge 1 commit into
adstep wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With "Show Decimal in BPM" enabled, BPMs were still rounded to the nearest tenth, so a chart authored at 100.001 BPM displayed as "100". Official DDR files frequently specify BPMs to 3 decimal places, and players want to see them accurately.
What changed
cached_bpm_text(insrc/screens/gameplay.rs) now rounds the decimal display to thousandths instead of tenths, and trims trailing zeros so precision only shows when it matters:100.001->100.001133.33->133.33100.000/150->100/150(clean integers still render with no decimal)This goes a bit further than the reference themes: ITGMania's BPMDisplay always rounds to an integer, and Simply Love shows at most one decimal. Anything finer than a thousandth still rounds, matching DDR's actual precision.