-
Notifications
You must be signed in to change notification settings - Fork 0
support ARM64 with official Ruby + jemalloc #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,17 +1,35 @@ | ||||||
| ARG RUBY_VERSION=2.7.8 | ||||||
| ARG VARIANT=jemalloc-slim | ||||||
| FROM quay.io/evl.ms/fullstaq-ruby:${RUBY_VERSION}-${VARIANT} as base | ||||||
| FROM ruby:${RUBY_VERSION}-slim | ||||||
|
|
||||||
| ARG BUNDLER_VERSION=2.4.20 | ||||||
| SHELL ["/bin/bash", "-o", "pipefail", "-c"] | ||||||
|
|
||||||
| # jemalloc for better memory management | ||||||
| RUN apt-get update && apt-get install -y --no-install-recommends libjemalloc2 \ | ||||||
| && JEMALLOC_PATH=$(find /usr/lib -name "libjemalloc.so.2" | head -1) \ | ||||||
| && [ -n "$JEMALLOC_PATH" ] || (echo "libjemalloc.so.2 not found" && exit 1) \ | ||||||
| && ln -sf "$JEMALLOC_PATH" /usr/lib/libjemalloc.so.2 \ | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛑 Logic Error: The symlink creation will fail if
Suggested change
|
||||||
| && rm -rf /var/lib/apt/lists/* | ||||||
| ENV LD_PRELOAD=/usr/lib/libjemalloc.so.2 | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛑 Portability Issue: Hardcoded LD_PRELOAD path may not work across ARM64 and AMD64 architectures. The jemalloc library path can vary between architectures.
Suggested change
|
||||||
|
|
||||||
| # Install build tools and native extension dependencies | ||||||
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||||||
| build-essential \ | ||||||
| libpq-dev \ | ||||||
| libffi-dev \ | ||||||
| && rm -rf /var/lib/apt/lists/* | ||||||
|
|
||||||
| ARG BUNDLER_VERSION=2.4.22 | ||||||
| RUN gem install -N bundler -v ${BUNDLER_VERSION} | ||||||
|
|
||||||
| ARG NODE_VERSION=18.18.0 | ||||||
| ARG YARN_VERSION=1.22.22 | ||||||
| ARG PNPM_VERSION=9.9.0 | ||||||
| RUN curl https://get.volta.sh | bash | ||||||
| ENV VOLTA_HOME /root/.volta | ||||||
| RUN apt-get update && apt-get install -y --no-install-recommends curl ca-certificates \ | ||||||
| && rm -rf /var/lib/apt/lists/* \ | ||||||
| && curl -fsSL https://get.volta.sh | bash | ||||||
| ENV VOLTA_HOME=/root/.volta | ||||||
| ENV VOLTA_FEATURE_PNPM=1 | ||||||
| ENV PATH $VOLTA_HOME/bin:/usr/local/bin:$PATH | ||||||
| ENV PATH=$VOLTA_HOME/bin:/usr/local/bin:$PATH | ||||||
| RUN volta install node@${NODE_VERSION} && volta install yarn@${YARN_VERSION} && volta install pnpm@${PNPM_VERSION} | ||||||
|
|
||||||
| RUN apt-get update \ | ||||||
|
|
@@ -23,28 +41,24 @@ RUN apt-get update \ | |||||
| graphicsmagick \ | ||||||
| file \ | ||||||
| tar \ | ||||||
| curl \ | ||||||
| ca-certificates \ | ||||||
| libmcrypt4 \ | ||||||
| shared-mime-info \ | ||||||
| libmcrypt4 \ | ||||||
| && rm -rf /var/lib/apt/lists/* | ||||||
|
|
||||||
| # Don't add g++/make to buildDeps, or purge will remove build-essential | ||||||
| WORKDIR /tmp | ||||||
| RUN set -ex \ | ||||||
| \ | ||||||
| && buildDeps=' \ | ||||||
| g++ \ | ||||||
| make \ | ||||||
| cmake \ | ||||||
| python \ | ||||||
| ' \ | ||||||
| && buildDeps='cmake python3' \ | ||||||
| && apt-get update \ | ||||||
| && apt-get install -y --no-install-recommends $buildDeps \ | ||||||
| && rm -rf /var/lib/apt/lists/* \ | ||||||
| \ | ||||||
| && curl -L https://github.com/BYVoid/OpenCC/archive/refs/tags/ver.1.1.9.tar.gz | tar -xz \ | ||||||
| && cd OpenCC-ver.1.1.9 \ | ||||||
| && REL_BUILD_DOCUMENTATION=OFF make install \ | ||||||
| \ | ||||||
| && apt-get purge -y --auto-remove $buildDeps \ | ||||||
| && cd ../ \ | ||||||
| && curl -L https://github.com/BYVoid/OpenCC/archive/refs/tags/ver.1.1.9.tar.gz | tar -xz | ||||||
|
|
||||||
| WORKDIR /tmp/OpenCC-ver.1.1.9 | ||||||
| RUN REL_BUILD_DOCUMENTATION=OFF make install | ||||||
|
|
||||||
| WORKDIR /tmp | ||||||
| RUN apt-get purge -y --auto-remove cmake python3 \ | ||||||
| && rm -rf OpenCC-ver.1.1.9 | ||||||
|
|
||||||
| WORKDIR /app | ||||||
Uh oh!
There was an error while loading. Please reload this page.