Add endorsement-proposal verify step#134
Open
devfans wants to merge 1 commit intopolynetwork:masterfrom
Open
Conversation
Contributor
Author
|
Also, with this change, a node will only proceed with the first proposed block hash from the same proposer. Need to be reviewed to avoid potential consensus incompatibility. |
devfans
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block endorsement and commitment messages are not verified against the local proposal. Here we add it to avoid invalid block sealing. This also indicates block endorsements and commitments will be ignored without relevant proposal available. These cases need to wait till the proposals are fetched in async.