[✨] {PROD4POD-635} Mock archive-related methods#1222
Draft
Conversation
added 22 commits
October 3, 2022 10:08
And set up properly jest to work in a jsdom environment
Up to 20% coverage now
Seems the right one for an abstract base class :white_check_mark: too
Added dep for testing
But this is going to need some more mock code, so will leave it like this
Which is needed to import zip files at this level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
We don't have a good polyPod mock that implements the importArchive (and followup) features. We will need it in order to work with #1204 properly, or we will have to mock it at a different level
🏗️ Fixes PROD4POD-635
This is a very old issue, and actually this is not starting the FakePod or MockPod, but making it complete enough to actually make it usable.
ℹ️ Other information
As usual, will try to make it a base to explore other changes and refactorings that will be needed at the repository level.